Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Minitest instead of Test::Unit #1152

Merged
merged 31 commits into from
Nov 22, 2016
Merged

Use Minitest instead of Test::Unit #1152

merged 31 commits into from
Nov 22, 2016

Conversation

frodsan
Copy link
Contributor

@frodsan frodsan commented Nov 21, 2016

Related to #1151

@frodsan
Copy link
Contributor Author

frodsan commented Nov 21, 2016

There is one test file that doesn't pass in isolation:

$ ruby -Ilib -Itest test/test_binder.rb
Run options: --seed 48927

# Running:

E* Listening on tcp://localhost:10001
.


Fabulous run in 0.005208s, 384.0246 runs/s, 192.0123 assertions/s.

  1) Error:
TestBinder#test_localhost_addresses_dont_alter_listeners_for_ssl_addresses:
NoMethodError: undefined method `check' for Puma::MiniSSL:Module
    /Users/frodsan/Code/frodsan/puma/lib/puma/binder.rb:149:in `block in parse'
    /Users/frodsan/Code/frodsan/puma/lib/puma/binder.rb:88:in `each'
    /Users/frodsan/Code/frodsan/puma/lib/puma/binder.rb:88:in `parse'
    test/test_binder.rb:27:in `test_localhost_addresses_dont_alter_listeners_for_ssl_addresses'

2 runs, 1 assertions, 0 failures, 1 errors, 0 skips

I'm investigating why, maybe a require is missing.

Update: fixed

@nateberkopec
Copy link
Member

LGTM

@nateberkopec nateberkopec self-assigned this Nov 22, 2016
@@ -1,10 +1,7 @@
require 'minitest/autorun'
require 'minitest/assertions'
require_relative "test_helper"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this one have to be require_relative?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops ... fixed :)

@nateberkopec
Copy link
Member

Praise be. Hopefully this shouldn't affect outstanding PRs too much.

@nateberkopec nateberkopec merged commit b638dd1 into puma:master Nov 22, 2016
@frodsan frodsan deleted the minitest branch November 22, 2016 15:07
@frodsan
Copy link
Contributor Author

frodsan commented Nov 22, 2016

👍 I hope not

@nateberkopec
Copy link
Member

just checked, doesnt look like any are affected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants