-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Minitest instead of Test::Unit #1152
Conversation
There is one test file that doesn't pass in isolation:
I'm investigating why, maybe a require is missing. Update: fixed |
LGTM |
@@ -1,10 +1,7 @@ | |||
require 'minitest/autorun' | |||
require 'minitest/assertions' | |||
require_relative "test_helper" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this one have to be require_relative
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops ... fixed :)
Praise be. Hopefully this shouldn't affect outstanding PRs too much. |
👍 I hope not |
just checked, doesnt look like any are affected |
Related to #1151